Re: [PATCH v4/GSoC/MICRO] revision: forbid combining --graph and --no-walk

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mar 17, 2015, 23:24 UTC
Message-ID: <CAPig+cRUqwcunX8mGKbsyBZPeTrz92jqvBJtDKfXvVzHvbun2g@mail.gmail.com>
In-Reply-To: <xmqq4mpjmcvv.fsf@gitster.dls.corp.google.com>

On Tue, Mar 17, 2015 at 7:18 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 14 quoted lines

> Dongcan Jiang <dongcan.jiang@gmail.com> writes:
>> diff --git a/t/t4052-stat-output.sh b/t/t4052-stat-output.sh
>> index b68afef..a989e8f 100755
>> --- a/t/t4052-stat-output.sh
>> +++ b/t/t4052-stat-output.sh
>> @@ -99,7 +99,7 @@ do
>>               test_cmp "$expect" actual
>>       '
>>
>> -     test "$cmd" != diff || continue
>> +     test "$cmd" != diff -a "$cmd" != show || continue
>
> I think we avoid -a and -o used with test (don't we have a write-up
> on this somewhere?).

The very last item in the shell script section of CodingGuidelines discusses it.

Show 8 quoted lines

> Write it like this
>
>         test "$cmd" != diff &&
>         test "$cmd" != show || continue
>
> or perhaps like this
>
>         case "$cmd" in diff|show) continue ;; esac