Re: [PATCH] Limit the size of the data block passed to SHA1_Update()

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Nov 1, 2015, 01:32 UTC
Message-ID: <CAPig+cRRjCDhdT-DvGtZqns1mMxygnxi=ZnRKzg+H_do7oRpqQ@mail.gmail.com>
In-Reply-To: <1446243122-21464-1-git-send-email-apahlevan@ieee.org>

On Fri, Oct 30, 2015 at 6:12 PM, Atousa Pahlevan Duprat <atousa.p@gmail.com> wrote:

Show 16 quoted lines

> Some implementations of SHA_Updates have inherent limits
> on the max chunk size. SHA1_MAX_BLOCK_SIZE can be defined
> to set the max chunk size supported, if required.  This is
> enabled for OSX CommonCrypto library and set to 1GiB.
> ---
> diff --git a/compat/apple-common-crypto.h b/compat/apple-common-crypto.h
> index c8b9b0e..83668fd 100644
> --- a/compat/apple-common-crypto.h
> +++ b/compat/apple-common-crypto.h
> @@ -16,6 +16,10 @@
>  #undef TYPE_BOOL
>  #endif
>
> +#ifndef SHA1_MAX_BLOCK_SIZE
> +#error "Using Apple Common Crypto library requires setting SHA1_MAX_BLOCK_SIZE"
> +#endif

You can drop the quotes around the argument to #error.