Re: [PATCH v2 05/11] ref-filter: skip deref specifier in match_atom_name()

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Dec 16, 2015, 21:11 UTC
Message-ID: <CAPig+cROdhYVW2f9ciwsMeXHNvu3BQP5bp4-no93x26dxor5cA@mail.gmail.com>
In-Reply-To: <1450279802-29414-6-git-send-email-Karthik.188@gmail.com>

On Wed, Dec 16, 2015 at 10:29 AM, Karthik Nayak <karthik.188@gmail.com> wrote:

> In upcoming patches we make calls to match_atom_name() with the '*'
> deref specifier still attached to the atom name. This causes
> undesirable errors, hence, if present skip over the '*' deref
> specifier in the atom name.

I'd drop the second sentence since it doesn't add much or any value. Instead, you might want to explain that skipping '*' is done as a convenience.

    Subsequent patches will call match_atom_name() with the '*' deref
    specifier still attached to the atom name so, as a convenience,
    skip over it on their behalf.

Show 8 quoted lines

> Signed-off-by: Karthik Nayak <Karthik.188@gmail.com>
> ---
> diff --git a/ref-filter.c b/ref-filter.c
> @@ -37,6 +37,10 @@ static int match_atom_name(const char *name, const char *atom_name, const char *
>  {
>         const char *body;
>
> +       /*  skip the deref specifier*/

Too many spaces before "skip". Too few spaces after "specifier".

Show 8 quoted lines

> +       if (name[0] == '*')
> +               name++;
> +
>         if (!skip_prefix(name, atom_name, &body))
>                 return 0; /* doesn't even begin with "atom_name" */
>         if (!body[0]) {
> --
> 2.6.4