Re: [PATCH] format-patch: allow --no-patch to disable patch output

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Apr 7, 2016, 21:30 UTC
Message-ID: <CAPig+cRNCwFmGW-Zo+osjceA6nb=6t3+rJ2uEbnyYxGfSWQ-Uw@mail.gmail.com>
In-Reply-To: <1460047599-9267-1-git-send-email-jacob.e.keller@intel.com>

On Thu, Apr 7, 2016 at 12:46 PM, Jacob Keller <jacob.e.keller@intel.com> wrote:

Show 8 quoted lines

> The documentation for format-patch indicates that --no-patch wilL
> suppress patch output. It also incorrectly mentions that -s will also
> suppress the patch output, but this is incorrect because -s is used to
> add the sign-off line first. Fix the documentation to remove the
> indication about -s. Fix builtin format-patch to prevent always adding
> the patch incase --no-patch is given. An alternative approach would be
> to remove --no-patch from the documentation for git-format-patch, and
> add an error check to indicate that --no-patch is not supported.

See [1] and [2].

[1]: http://thread.gmane.org/gmane.comp.version-control.git/290023 [2]: b73a1bc (git-format-patch.txt: don't show -s as shorthand for multiple options, 2016-03-27)

> Add a test for --no-patch to ensure it functions as expected.
>
> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>