Re: [PATCH] worktree: accept -f as short for --force for removal

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Apr 18, 2018, 05:01 UTC
Message-ID: <CAPig+cRHW3TwrqwrY9R0-v50Z5U8uz99Hn+ERtP_1Ey2K_Vk=Q@mail.gmail.com>
In-Reply-To: <xmqq4lk9l64o.fsf@gitster-ct.c.googlers.com>

On Tue, Apr 17, 2018 at 8:17 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 16 quoted lines

> Eric Sunshine <sunshine@sunshineco.com> writes:
>> Makes sense. A possible rewrite (of the entire commit message):
>>
>>     worktree: remove: recognize -f as short for --force
>>
>>     Many commands support a --force option, frequently abbreviated as
>>     -f, however, "git worktree remove"'s hand-rolled OPT_BOOL forgets
>>     to recognize the short form, despite git-worktree.txt documenting
>>     -f as supported. Replace OPT_BOOL with OPT__FORCE, which provides
>>     -f for free, and makes 'remove' consistent with 'add' option
>>     parsing (which also specifies the PARSE_OPT_NOCOMPLETE flag).
>>
> Looks better.  I am not sure if s/--force/-f/ in the synopsis
> section is warranted, but '-f' is commonly understood as '--force'
> (and that is the point of this patch after all), so it is probably
> an improvement to be briefer.

I meant to mention the synopsis change in the rewritten commit message. The s/--force/-f/ for 'remove' makes it consistent with the how it's shown for 'add' in the synopsis. (Changing it the other way, so 'add' shows --force would also work.)