Re: [PATCH] t0005: ksh93 portability workaround

From: Eric Sunshine <sunshine@sunshineco.com>
Date: May 31, 2016, 22:49 UTC
Message-ID: <CAPig+cRD8aTNJxvfkc-5Xjr6_pKRzAi3SpZ7JCZcRYMQFT_xMg@mail.gmail.com>
In-Reply-To: <xmqqinxt3kwq.fsf@gitster.mtv.corp.google.com>

On Tue, May 31, 2016 at 6:47 PM, Junio C Hamano <gitster@pobox.com> wrote:

> The test has two things ksh93 does not happy about:

s/does/is/

Show 14 quoted lines

>  * It thinks "(( command1; command2 ) | command3)" is a perfectly
>    sane way to write a pipeline.  ksh93, unlike other POSIX shells,
>    does not like the two open parentheses next to each other for
>    whatever reason it has.
>
>  * It adds 256, unlike 128 that are used by other POSIX shells, to
>    the signal number that caused the process to die when coming up
>    with the exit status.
>
> What is interesting is that we knew about the latter issue and had a
> workaround in the test-sigchain test when verifying that SIGTERM
> works OK, but we didn't have corresponding workaround for SIGPIPE.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>