Re: [RFC PATCH] vreportf: ensure sensible ordering of normal and error output
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Dec 1, 2021, 05:38 UTC
- Message-ID
- <CAPig+cRB45nwUin4Lv-j2dAQob1SSu7hGyM2c3E8G2ym_uFB2w@mail.gmail.com>
- In-Reply-To
- <CAPig+cT+YfgBG3Aqszp+y7iy_megboECZy3NkMqUjBj7=Z661A@mail.gmail.com>
On Tue, Nov 30, 2021 at 9:36 PM Eric Sunshine <sunshine@sunshineco.com> wrote:
Show 14 quoted lines
> On Tue, Nov 30, 2021 at 3:47 PM Jeff King <peff@peff.net> wrote: > > On Tue, Nov 30, 2021 at 09:05:54AM -0500, Eric Sunshine wrote: > > > (1) I don't think the practice is documented anywhere, so people -- > > > including me when I wrote builtin/worktree.c -- might not know about > > > it. Indeed, we don't seem to be entirely consistent about doing it > > > this way. Randomly picking submodule-helper.c, for instance, I see > > > status-like messages going to stdout: > > > > Yeah, we've definitely not been consistent here. There's no silver > > bullet for this aside from vigilance during review, but probably laying > > out guidelines could help. > > Thanks for the reference. I'll take a stab at adding a blurb about > this to CodingGuidelines.
I just posted a patch which updates CodingGuidelines to talk a bit about this: https://lore.kernel.org/git/20211201053214.2902-1-sunshine@sunshineco.com/