Re: [PATCH v3 0/4] t: new helper test_line_count_cmd

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jun 19, 2021, 05:50 UTC
Message-ID: <CAPig+cR7tUXB4=j3fGHN07=tPJ-skGb_6M7SExTq5eAH7FSwOQ@mail.gmail.com>
In-Reply-To: <20210619013035.26313-1-congdanhqx@gmail.com>

On Fri, Jun 18, 2021 at 9:31 PM Đoàn Trần Công Danh <congdanhqx@gmail.com> wrote:

> Change in v3 since v2:
> * --err was dropped entirely
> * --out is not an option anymore, <binops> and <value> is the first two
>   arguments that fed into test_line_count_cmd

When I read the previous version of this series, I found that many of the instances where test_line_count_cmd() were used became quite noisy, to the point that it was difficult to see at-a-glance the command being tested. As an experiment, on top of your patch 1, I crafted a patch which made `--out` and `--err` optional (defaulting to `--out`). That helped reduce the noise level a good deal, however, I still found it too noisy. Consequently, I crafted a second patch which renamed the function to test_output_count(), and only then did the noise level drop sufficiently that the command being tested didn't entirely disappear into the background.

Since you've dropped the `--out` and `--err` options entirely, I wonder if now would be a good time to shorten the function name, as well, in order to further reduce the noise level. Since it now only tests stdout (and doesn't deal with stderr), a name even shorter than what I tried for the last version might be even better. So, for instance, the name test_out_count() might not be too bad:

    test_out_count = 0 git ls-files -o &&