Re: [PATCH/RFC] Makefile: dedup list of files obtained from ls-files

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Apr 22, 2019, 03:23 UTC
Message-ID: <CAPig+cR5yMtdBA0HgLZ6k-j3NeMS+4UeEKgRiEpZ0YGrW_L0cg@mail.gmail.com>
In-Reply-To: <xmqqy343a43b.fsf@gitster-ct.c.googlers.com>

On Sun, Apr 21, 2019 at 9:19 AM Junio C Hamano <gitster@pobox.com> wrote:

Show 10 quoted lines

> diff --git a/Makefile b/Makefile
> @@ -822,12 +822,12 @@ VCSSVN_LIB = vcs-svn/lib.a
> -LIB_H := $(shell git ls-files '*.h' ':!t/' ':!Documentation/' 2>/dev/null || \
> +LIB_H := $(shell (git ls-files '*.h' ':!t/' ':!Documentation/' 2>/dev/null || \
>         $(FIND) . \
>         -name .git -prune -o \
>         -name t -prune -o \
>         -name Documentation -prune -o \
> -       -name '*.h' -print)
> +       -name '*.h' -print) | sort -u)

GNU make's "sort" function also de-dups, so an alternative is:

    LIB_H := $(sort $(shell ...))