Re: [PATCH] t4038-diff-combined: quote paths with whitespace

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mar 17, 2019, 23:11 UTC
Message-ID: <CAPig+cR5uqE+9smKcvZr0oaw2XyqWsYORwAga4WLUX5N+hU4bA@mail.gmail.com>
In-Reply-To: <20190317230239.10131-1-tmz@pobox.com>

On Sun, Mar 17, 2019 at 7:02 PM Todd Zullinger <tmz@pobox.com> wrote:

> d76ce4f734 ("log,diff-tree: add --combined-all-paths option",
> 2019-02-07) added tests for files containing tabs.

s/files/filenames/

Show 9 quoted lines

> When the tests are run with bash, the lack of quoting during the file
> setup causes 'ambiguous redirect' errors.
>
> Signed-off-by: Todd Zullinger <tmz@pobox.com>
> ---
>
> I noticed these failures while running in a repo where I happened
> to have TEST_SHELL_PATH=/bin/bash set.  I wonder if we should
> have a test matrix which uses bash to catch these sort of things?

Maybe just extending "make test-lint" to catch these would suffice.