git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] sequencer: break out of loop explicitly

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Oct 31, 2018, 17:28 UTC
Message-ID
<CAPig+cR-W1bQ7wY8k8Zok3hCBxHL8uXmUA2p2Tc9pYYXc7Zr+g@mail.gmail.com>
In-Reply-To
<nycvar.QRO.7.76.6.1810311553480.4546@tvgsbejvaqbjf.bet>

On Wed, Oct 31, 2018 at 10:54 AM Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 11 quoted lines
> On Tue, 30 Oct 2018, Martin Ågren wrote:
> > Rewrite the loop to a more idiomatic variant which doesn't muck with
> > `len` in the loop body. That should help compilers and human readers
> > figure out what is going on here. But do note that we need to update
> > `len` since it is not only used just after this loop (where we could
> > have used `i` directly), but also later in this function.
> >
> > Signed-off-by: Martin Ågren <martin.agren@gmail.com>
> > ---
>
> ACK. Thanks for cleaning up after me,
Looks good to me, as well. Thanks for working on it.
Previous: Johannes SchindelinNext: Martin Ågren
Message 7 of 8 in “sequencer: clarify intention to break out of loop”
  1. sequencer: clarify intention to break out of loopMartin Ågren, Oct 28, 2018
  2. Eric SunshineOct 28, 2018
  3. Martin ÅgrenOct 28, 2018
  4. Junio C HamanoOct 29, 2018
  5. sequencer: break out of loop explicitlyMartin Ågren, Oct 30, 2018
  6. Johannes SchindelinOct 31, 2018
  7. Eric SunshineOct 31, 2018
  8. Martin ÅgrenOct 31, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.