Re: [PATCH v2] sequencer: break out of loop explicitly
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Oct 31, 2018, 17:28 UTC
- Message-ID
- <CAPig+cR-W1bQ7wY8k8Zok3hCBxHL8uXmUA2p2Tc9pYYXc7Zr+g@mail.gmail.com>
- In-Reply-To
- <nycvar.QRO.7.76.6.1810311553480.4546@tvgsbejvaqbjf.bet>
On Wed, Oct 31, 2018 at 10:54 AM Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
Show 11 quoted lines
> On Tue, 30 Oct 2018, Martin Ågren wrote: > > Rewrite the loop to a more idiomatic variant which doesn't muck with > > `len` in the loop body. That should help compilers and human readers > > figure out what is going on here. But do note that we need to update > > `len` since it is not only used just after this loop (where we could > > have used `i` directly), but also later in this function. > > > > Signed-off-by: Martin Ågren <martin.agren@gmail.com> > > --- > > ACK. Thanks for cleaning up after me,
Looks good to me, as well. Thanks for working on it.