git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] color: protect against out-of-bounds array access/assignment

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Aug 2, 2018, 17:45 UTC
Message-ID
<CAPig+cQyYRvF5QkJRUi6W2LiOo_poxWyJw9dn+FOimb1ryX8Mg@mail.gmail.com>
In-Reply-To
<xmqqftzw3c21.fsf@gitster-ct.c.googlers.com>
On Thu, Aug 2, 2018 at 1:37 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 8 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> > ACK!
>
> Did you write a buggy caller that would have been caught or helped
> with this change?  You did not write the callee that is made more
> defensive with this patch, so I am being curious as to where that
> Ack is coming from (I wouldn't have felt curious if this were
> a reviewed-by instead).
The code being made more defensive with this patch was authored by Dscho[1].
[1]: 295d949cfa (color: introduce support for colorizing stderr, 2018-04-21)
Previous: Junio C HamanoNext: Junio C Hamano
Message 4 of 8 in “color: protect against out-of-bounds array access/assignment”
  1. color: protect against out-of-bounds array access/assignmentEric Sunshine, Aug 2, 2018
  2. Johannes SchindelinAug 2, 2018
  3. Junio C HamanoAug 2, 2018
  4. Eric SunshineAug 2, 2018
  5. Junio C HamanoAug 2, 2018
  6. Jeff KingAug 2, 2018
  7. Jonathan NiederAug 3, 2018
  8. Eric SunshineAug 3, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.