Re: [outreachy] sent in my first patch

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Oct 14, 2022, 00:08 UTC
Message-ID: <CAPig+cQxuWfibPR9O5qZrU4mkuOL48gftRtJ86gzvH0hgJBMOg@mail.gmail.com>
In-Reply-To: <CA+PPyiH0VqXdO1LfXP7CaM=HnBPWqvHd4DTE5EOMEcb58DCPCA@mail.gmail.com>

On Thu, Oct 13, 2022 at 5:46 PM NSENGIYUMVA WILBERFORCE <nsengiyumvawilberforce@gmail.com> wrote:

Show 5 quoted lines

> I have been able to submit a patch for a microproject. Many thanks
> Johannes Schindelin for /allow. My CI tests were failing and I had no
> idea why they were failing.
>
> The PR is https://github.com/git/git/pull/1362

It appears that your patch did not get sent to the mailing list because the patch's commit message failed GitGitGadget's validation check. In particular, the commit message should start with a summary line, followed by one blank line, and then the more detailed description of the change. The summary line should be formatted as "<area>: <short-description>", where <area> is the bit of code you are touching. The project also prefers the commit message to be written in imperative mood, as if the commit message is telling the code in the project how to change itself. So, you might rewrite the commit message (by amending the commit) to read something like this:

    [OUTREACHY] t1002: modernize outdated conditional

    Tests in this script use an unusual and hard-to-reason-about
    conditional construct:

        if <condition>; then false; else :; fi

    Change them to use the more idiomatic construct:

        ! <condition>

    to make them easier to understand at a glance.

Then "force push" the revised patch to GitHub. Since this is a single-patch pull request, you probably also want to edit the pull-request's description on GitHub to remove all the text except for the "Cc:" entry or entries.

GitGitGadget also complained that you don't have a public email address registered with GitHub, so you should address that problem, too, if you haven't already.

Finally, re-"/submit" the pull request and observe the comments GitGitGadet adds to the pull request to see if it discovers any additional issues.