git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] builtin/init-db.c: fix a sparse warning

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Aug 28, 2020, 22:20 UTC
Message-ID
<CAPig+cQxjYA_LdbaGYOCACPSn=DhpFA-+5tb76BxnveT66w45A@mail.gmail.com>
In-Reply-To
<8d4b4011-b8a2-c0e0-a3f2-28c7bbec040b@ramsayjones.plus.com>

On Fri, Aug 28, 2020 at 4:47 PM Ramsay Jones <ramsay@ramsayjones.plus.com> wrote:

Show 6 quoted lines
> If you need to re-roll your 'es/worktree-repair' branch, could you
> please squash this into the relevant patch (commit 44a466ca7f (init:
> make --separate-git-dir work from within linked worktree, 27-08-2020)).
>
> -                       git_dir = strbuf_detach(&sb, 0);
> +                       git_dir = strbuf_detach(&sb, NULL);

Thanks. I misremembered the purpose of the second argument, thinking that it was a size hint which would be passed along to strbuf_init().

Previous: Ramsay Jones
Message 2 of 2 in “builtin/init-db.c: fix a sparse warning”
  1. builtin/init-db.c: fix a sparse warningRamsay Jones, Aug 28, 2020
  2. Eric SunshineAug 28, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.