git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] git clone: check for non-empty directory

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Jul 2, 2020, 05:32 UTC
Message-ID
<CAPig+cQwJKSVMP8G7E62bESERYsAFTUN2PBX32YWMhECjU=qTQ@mail.gmail.com>
In-Reply-To
<CAPig+cT+cXuM3Asu6+Z25pGV2uRm6K1iAeYVhic9kqk1mS84-g@mail.gmail.com>
On Wed, Jul 1, 2020 at 12:00 PM Eric Sunshine <sunshine@sunshineco.com> wrote:
Show 8 quoted lines
> One other observation: To preserve bisectability (git-bisect) of
> git.git itself, we want to ensure that the entire test suite still
> passes at each point in a patch series. Making this change to the test
> in its own patch introduces a failure into the test suite, which is
> undesirable. One way to address this shortcoming would be to
> temporarily change this test from 'test_must_succeed' to
> 'test_must_fail', and then flip it back to 'test_must_succeed' in
> patch 2/2. [...]

And another correction: I meant 'test_expect_success' and 'test_expect_failure', respectively.

Previous: Eric SunshineNext: Ben Wijen
Message 5 of 14 in “git clone with --separate-git-dir destroys existing directory content”
  1. 0/2 git clone with --separate-git-dir destroys existing directory contentBen Wijen, Jul 1, 2020
  2. 1/2 git clone: check for non-empty directoryBen Wijen, Jul 1, 2020
  3. Eric SunshineJul 1, 2020
  4. Eric SunshineJul 1, 2020
  5. Eric SunshineJul 2, 2020
  6. 2/2 git clone: don't clone into non-empty directoryBen Wijen, Jul 1, 2020
  7. Eric SunshineJul 1, 2020
  8. BenJul 2, 2020
  9. Eric SunshineJul 1, 2020
  10. 0/1 git clone: don't clone into non-empty directoryBen Wijen, Jul 2, 2020
  11. 1/1 git clone: don't clone into non-empty directoryBen Wijen, Jul 2, 2020
  12. Junio C HamanoJul 6, 2020
  13. 1/1 git clone: don't clone into non-empty directoryBen Wijen, Jul 10, 2020
  14. 0/1 git clone: don't clone into non-empty directoryBen Wijen, Jul 10, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.