Re: [PATCH 8/8] Makefiles: add and use wildcard "mkdir -p" template
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Dec 17, 2021, 06:09 UTC
- Message-ID
- <CAPig+cQt47U9E8kUFiTBecEPcTaLhRCi5X_T=nPqZM-HJR=n0g@mail.gmail.com>
- In-Reply-To
- <patch-8.8-aca560ca410-20211217T012902Z-avarab@gmail.com>
On Thu, Dec 16, 2021 at 11:40 PM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
Show 6 quoted lines
> [...] > But as it turns out we can use this neat trick of only doing a "mkdir > -p" if the $(wildcard) macro tells us the path doesn't exist. A re-run > of a performance test similar to thatnoted downthread of [1] in [2] > shows that this is faster, in addition to being less verbose and more > reliable (this uses my "git-hyperfine" thin wrapper for "hyperfine"[3]):
s/thatnoted/that noted/
Show 9 quoted lines
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> > --- > diff --git a/shared.mak b/shared.mak > @@ -90,3 +92,18 @@ ifndef V > +## Is racy, but in a good way; we might redundantly (and safely) > +## "mkdir -p" when running in parallel, but won't need to exhaustively > +## individual rules for "a" -> "prefix" -> "dir" -> "file" if given a > +## "a/prefix/dir/file". This can instead be inserted at the start of > +## the "a/prefix/dir/file" rule.
Is there a word missing between "exhaustively" and "individual"?