Re: [PATCH 1/1] git-send-email causes failures because of wrong option specifications

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Nov 26, 2023, 02:39 UTC
Message-ID: <CAPig+cQq0myrGFro_MO8H+x8W52UuivX=TzShxb5diVp2nLh7g@mail.gmail.com>
In-Reply-To: <20231125094429.12025-2-linux@tux.freedom.nl>

On Sat, Nov 25, 2023 at 4:52 AM H.Merijn Brand - Tux <linux@tux.freedom.nl> wrote:

Show 16 quoted lines

> ...
> git-2.43.0 🐧 perl -Iperl git-send-email.perl --help
> Duplicate specification "cc-cover|cc-cover!" for option "cc-cover"
> Duplicate specification "no-cc-cover" for option "no-cc-cover"
> ...
> Signed-off-by: H.Merijn Brand - Tux <linux@tux.freedom.nl>
> ---
> diff --git a/git-send-email.perl b/git-send-email.perl
> @@ -506,36 +505,27 @@ sub config_regexp {
> -                   "no-signed-off-cc|no-signed-off-by-cc" => sub {$signed_off_by_cc = 0},
> -                   "cc-cover|cc-cover!" => \$cover_cc,
> -                   "no-cc-cover" => sub {$cover_cc = 0},
> -                   "to-cover|to-cover!" => \$cover_to,
> -                   "no-to-cover" => sub {$cover_to = 0},
> +                   "cc-cover!" => \$cover_cc,
> +                   "to-cover!" => \$cover_to,

Thanks for submitting a patch to address this issue. It matches very closely an earlier patch[1] addressing the same purpose which has already made it into Junio's "next" branch.

[1]: https://lore.kernel.org/git/20231116193014.470420-3-tmz@pobox.com/