Re: [PATCH 1/1] chainlint: fix for core.autocrlf=true
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Aug 15, 2018, 16:32 UTC
- Message-ID
- <CAPig+cQkHiKDUhMJEdOewnEHTiTvdULwhZGd_h_94W0+zzGb0Q@mail.gmail.com>
- In-Reply-To
- <d0d1d49d6f3e741e9c048041a2f467742bce4bdc.1534343621.git.gitgitgadget@gmail.com>
On Wed, Aug 15, 2018 at 10:33 AM Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com> wrote:
Show 10 quoted lines
> The `chainlint` target compares actual output to expected output, where > the actual output is generated from files that are specifically checked > out with LF-only line endings. So the expected output needs to be > checked out with LF-only line endings, too. > > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> > --- > diff --git a/t/.gitattributes b/t/.gitattributes > @@ -1,4 +1,5 @@ > +/chainlint/*.expect eol=lf
Make sense. I did touch t/.gitignore for the chainlint series but never thought to examine t/.gitattributes (and wasn't necessarily aware of its existence). Had I looked inside .gitattributes, perhaps I would have intuited the need for this change. Thanks for handling it.