Re: [PATCH 18/18] Clearly rewrite double dereference
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Jun 7, 2013, 04:04 UTC
- Message-ID
- <CAPig+cQdwO9dBr2xVC4z8=M6_ELJdLNhzZa5DUW-MCo6_gOAJA@mail.gmail.com>
- In-Reply-To
- <1370547263-13558-19-git-send-email-celestin.matte@ensimag.fr>
On Thu, Jun 6, 2013 at 3:34 PM, Célestin Matte <celestin.matte@ensimag.fr> wrote:
Show 19 quoted lines
> @$var structures are re-written in the following way: @{ $var }
> It makes them more readable.
>
> Signed-off-by: Célestin Matte <celestin.matte@ensimag.fr>
> Signed-off-by: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
> ---
> contrib/mw-to-git/git-remote-mediawiki.perl | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl b/contrib/mw-to-git/git-remote-mediawiki.perl
> index 20ddccb..06e6f4d 100755
> --- a/contrib/mw-to-git/git-remote-mediawiki.perl
> +++ b/contrib/mw-to-git/git-remote-mediawiki.perl
> @@ -233,7 +233,7 @@ sub get_mw_tracked_pages {
> sub get_mw_page_list {
> my $page_list = shift;
> my $pages = shift;
> - my @some_pages = @$page_list;
> + my @some_pages = @{ $page_list };Minor style nit: Existing code in git-remote-mediawiki.perl does not have whitespace inside @{}. It prefers @{$foo} rather than @{ $foo }. This nit applies to this entire patch.
Show 55 quoted lines
> while (@some_pages) {
> my $last_page = $SLICE_SIZE;
> if ($#some_pages < $last_page) {
> @@ -733,7 +733,7 @@ sub import_file_revision {
>
> print {*STDOUT} "commit refs/mediawiki/${remotename}/master\n";
> print {*STDOUT} "mark :${n}\n";
> - print {*STDOUT} "committer ${author} <${author}\@${wiki_name}> " . $date->epoch . " +0000\n";
> + print {*STDOUT} "committer ${author} <${author}\@{ ${wiki_name} }> " . $date->epoch . " +0000\n";
> literal_data($comment);
>
> # If it's not a clone, we need to know where to start from
> @@ -759,7 +759,7 @@ sub import_file_revision {
> print {*STDOUT} "reset refs/notes/${remotename}/mediawiki\n";
> }
> print {*STDOUT} "commit refs/notes/${remotename}/mediawiki\n";
> - print {*STDOUT} "committer ${author} <${author}\@${wiki_name}> " . $date->epoch . " +0000\n";
> + print {*STDOUT} "committer ${author} <${author}\@{ ${wiki_name} }> " . $date->epoch . " +0000\n";
> literal_data('Note added by git-mediawiki during import');
> if (!$full_import && $n == 1) {
> print {*STDOUT} "from refs/notes/${remotename}/mediawiki^0\n";
> @@ -881,7 +881,7 @@ sub mw_import_revids {
> my $n_actual = 0;
> my $last_timestamp = 0; # Placeholer in case $rev->timestamp is undefined
>
> - foreach my $pagerevid (@$revision_ids) {
> + foreach my $pagerevid (@{ $revision_ids }) {
> # Count page even if we skip it, since we display
> # $n/$total and $total includes skipped pages.
> $n++;
> @@ -916,7 +916,7 @@ sub mw_import_revids {
> my $page_title = $result_page->{title};
>
> if (!exists($pages->{$page_title})) {
> - print {*STDERR} "${n}/", scalar(@$revision_ids),
> + print {*STDERR} "${n}/", scalar(@ { $revision_ids }),
> ": Skipping revision #$rev->{revid} of ${page_title}\n";
> next;
> }
> @@ -949,7 +949,7 @@ sub mw_import_revids {
> # If this is a revision of the media page for new version
> # of a file do one common commit for both file and media page.
> # Else do commit only for that page.
> - print {*STDERR} "${n}/", scalar(@$revision_ids), ": Revision #$rev->{revid} of $commit{title}\n";
> + print {*STDERR} "${n}/", scalar(@{ $revision_ids }), ": Revision #$rev->{revid} of $commit{title}\n";
> import_file_revision(\%commit, ($fetch_from == 1), $n_actual, \%mediafile);
> }
>
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html