git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH][Outreachy] branch: allow - as abbreviation of '@{-1}'

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Mar 18, 2016, 18:13 UTC
Message-ID
<CAPig+cQYYPmUtOoTGDzzQJC8n+9UoVEskmnZ19E=rroyU5+Pkg@mail.gmail.com>
In-Reply-To
<xmqqvb4jrcle.fsf@gitster.mtv.corp.google.com>
On Fri, Mar 18, 2016 at 12:10 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 24 quoted lines
> On the submitted patch itself, in decreasing order of importance:
>
>  * The approach you took turns every "-" that appears as a command
>    line argument into "@{-1}", but it does so without even checking
>    where "-" appears on the command line is meant to take a branch
>    name.  This closes the door to later add an option that takes "-"
>    as an argument that means something different (e.g. one common
>    use of "-" is to mean "the standard input" when a filename is
>    expected).
>
>  * There is no explanation and justification in the proposed log
>    message why you took a particular approach.  Why is that a good
>    approach?  What are the possible downsides?  What were the
>    alternatives (if any), and why is the approach chosen is better
>    than them?
>
>  * We forbid declaration-after-statement in our codebase.
>
>  * When you do not yet have the "branch I was previously on", I
>    imagine that your implementation would give you this:
>    [...]
>
>  * You do not need the brace pairs around the body of these new
>    "for" or "if" statements.

Also for consideration: You'd probably also want to add a test or two or three to verify that "-" works as intended, and a documentation update may be warranted.

Previous: Eric SunshineNext: elena petrashen
Message 5 of 8 in “[Outreachy] branch: allow - as abbreviation of '@{-1}'”
  1. [Outreachy] branch: allow - as abbreviation of '@{-1}'Elena Petrashen, Mar 18, 2016
  2. Junio C HamanoMar 18, 2016
  3. Mike HommeyMar 18, 2016
  4. Eric SunshineMar 18, 2016
  5. Eric SunshineMar 18, 2016
  6. elena petrashenMar 21, 2016
  7. Eric SunshineMar 21, 2016
  8. Junio C HamanoMar 21, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.