Re: t4151 missing quotes

From: Eric Sunshine <sunshine@sunshineco.com>
Date: May 9, 2016, 17:57 UTC
Message-ID: <CAPig+cQS32O0jxJkWRB2r5vQw3LHVeD_vK+3O9Q3ominO38S2g@mail.gmail.com>
In-Reply-To: <CALR6jEgaNSAQOpxSK46h71PMRhakDa=UCC5gbTyg77BcaOaoPg@mail.gmail.com>

[please don't top-post on this list]

On Mon, May 9, 2016 at 12:35 PM, Armin Kunaschik <megabreit@googlemail.com> wrote:

> Sorry, this was my first patch to the list. I'll do better :-)
> You are right about the "wc -l" parts. Maybe I was a bit over
> pessimistic. Throw away my last mail.

Done :-)

> In my case test 9 ran unsuccessful because of an empty "git ls-files -u"

Okay, that makes perfect sense and does indeed deserve to be fixed.

> This reduces the diff to this one (hopefully the right way now):

Perhaps you can turn this into a proper patch acceptable for inclusion in the project. If you're interested in attempting this, take a look at Documentation/Submitting.

Show 18 quoted lines

> *** ./t4151-am-abort.sh.orig    Fri Apr 29 23:37:00 2016
> --- ./t4151-am-abort.sh Mon May  9 18:28:18 2016
> ***************
> *** 82,88 ****
>         test 4 = "$(cat otherfile-4)" &&
>         git am --abort &&
>         test_cmp_rev initial HEAD &&
> !       test -z $(git ls-files -u) &&
>         test_path_is_missing otherfile-4
>   '
>
> --- 82,88 ----
>         test 4 = "$(cat otherfile-4)" &&
>         git am --abort &&
>         test_cmp_rev initial HEAD &&
> !       test -z "$(git ls-files -u)" &&
>         test_path_is_missing otherfile-4
>   '

This fix looks fine. Thanks.