Re: [PATCH v3] pkt-line: allow writing of LARGE_PACKET_MAX buffers

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Dec 10, 2014, 08:36 UTC
Message-ID: <CAPig+cQQThA7wiz8iwkKX=ipg1n5w+gyeS8NqtbjGui986Hn+g@mail.gmail.com>
In-Reply-To: <20141210073447.GA20298@peff.net>

On Wed, Dec 10, 2014 at 2:34 AM, Jeff King <peff@peff.net> wrote:

> Below is a another iteration on the patch. The actual code changes are
> the same as the strbuf one, but the tests take care to avoid assuming
> the filesystem can handle such a long path. Testing on Windows and OS X
> is appreciated.

All three new tests fail on OS X. Thus far brief examination of the first failing tests shows that 'expect' and 'actual' differ:

expect:
    long
    master

actual:
    master

Show 5 quoted lines

> Note that in addition to cheating on the creation of the long ref, I had
> to tweak the fetch test a little to avoid writing the loose ref there,
> too. That makes the test a little weaker (it is not as "end to end",
> checking that all parts of fetch can handle it), but it does check the
> thing we are changing here, that the protocol code can handle it.