Re: [PATCH v7 1/9] connect: document why we sometimes call get_port after get_host_and_port

From: Eric Sunshine <sunshine@sunshineco.com>
Date: May 22, 2016, 02:40 UTC
Message-ID: <CAPig+cQPpX7w7gJc_F_Jz=1PpiK_Q+tSSBrCwmhW84QuwX20kw@mail.gmail.com>
In-Reply-To: <20160521231732.4888-2-mh@glandium.org>

On Sat, May 21, 2016 at 7:17 PM, Mike Hommey <mh@glandium.org> wrote:

Show 13 quoted lines

> Signed-off-by: Mike Hommey <mh@glandium.org>
> ---
> diff --git a/connect.c b/connect.c
> @@ -742,6 +742,12 @@ struct child_process *git_connect(int fd[2], const char *url,
>                         transport_check_allowed("ssh");
>                         get_host_and_port(&ssh_host, &port);
>
> +                       /* get_host_and_port may not return a port even when
> +                        * there is one: In the [host:port]:path case,
> +                        * get_host_and_port is called with "[host:port]" and
> +                        * returns "host:port" and NULL.
> +                        * In that specific case, we still need to split the
> +                        * port. */

Style:

    /*
     * This is a multi-
     * line comment.
     */

>                         if (!port)
>                                 port = get_port(ssh_host);