git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] status: learn --color for piping colored output

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Feb 5, 2021, 06:23 UTC
Message-ID
<CAPig+cQMeK_vPuS-V3EAQUDHZaJ21VSgPV0m1CB_LZ8=9Bbgzw@mail.gmail.com>
In-Reply-To
<CACPHW2WbY+c914vHV8cjfBC1GstF7PxfQFr-NF=EUhcF0YaCzQ@mail.gmail.com>
On Wed, Feb 3, 2021 at 4:08 PM Lance Ward <ljward10@gmail.com> wrote:
Show 8 quoted lines
> I made all the changes you suggested and split it into two
> independent changes:
>
> This patch handles the --color option:
> https://github.com/git/git/pull/955
>
> This patch fixes the coloring inconsistency:
> https://github.com/git/git/pull/954

Thanks for being responsive and indulging this reviewer. The two-patch approach turned out to be concise and easy to digest. The bug fix -- which effectively turned out to be a one-liner -- is an especially nice improvement over the earlier version, and the implementation of the new --color option boiled down very nicely to a really minimal amount of straightforward code.

Previous: Lance Ward
Message 8 of 8 in “status: learn --color for piping colored output”
  1. status: learn --color for piping colored outputLance Ward via GitGitGadget, Jan 30, 2021
  2. Eric SunshineJan 31, 2021
  3. Lance WardJan 31, 2021
  4. Eric SunshineJan 31, 2021
  5. Lance WardFeb 2, 2021
  6. Eric SunshineFeb 3, 2021
  7. Lance WardFeb 3, 2021
  8. Eric SunshineFeb 5, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.