Re: [PATCH 1/5] serve: mark has_capability() as static

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jun 16, 2021, 16:28 UTC
Message-ID: <CAPig+cQLRGL+jUkJi9n8_6LUpzxn-1XiCyvzCgiY38wjTi+TbQ@mail.gmail.com>
In-Reply-To: <patch-1.5-4f74d7d34c4-20210616T141332Z-avarab@gmail.com>

On Wed, Jun 16, 2021 at 10:16 AM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

Show 16 quoted lines

> The has_capability() function introduced in ed10cb952d3 (serve:
> introduce git-serve, 2018-03-15) has never been used anywhere except
> serve.c, so let's mark it as static.
>
> It was later changed from "extern" in 554544276a6 (*.[ch]: remove
> extern from function declarations using spatch, 2019-04-29), but we
> could have simply marked it as "static" instead.
>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
> diff --git a/serve.h b/serve.h
> @@ -2,9 +2,6 @@
>  struct strvec;
> -int has_capability(const struct strvec *keys, const char *capability,
> -                  const char **value);
> -

`strvec` isn't used anywhere in this header following removal of has_capability(), so the forward declaration could be dropped, as well.