Re: [RFC][GSoC][PATCH] t9160: Change test -(d | f) to test_path_is_*

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Feb 14, 2023, 23:30 UTC
Message-ID: <CAPig+cQK_aW4m4LToYwDVF7Fw_cHjQVMpg7OS=ptwWjhwUCt8A@mail.gmail.com>
In-Reply-To: <CADE8Naoq4N9EpSfb8=ADPRLeAsmjVhL+ayOzhS=syaZ0PQh71w@mail.gmail.com>

On Fri, Feb 10, 2023 at 6:32 AM Vinayak Dev <vinayakdev.sci@gmail.com> wrote:

Show 8 quoted lines

> On Fri, 10 Feb 2023 at 16:38, Eric Sunshine <sunshine@sunshineco.com> wrote:
> > On Fri, Feb 10, 2023 at 3:05 AM Vinayak Dev <vinayakdev.sci@gmail.com> wrote:
> > As with the other GSoC patch you submitted[1], this one is also
> > missing the "---" line below your sign-off, which tells git-am where
> > the commit message ends. As mentioned in [2] you may need to adjust
> > your tools or workflow to prevent the "---" line from being stripped.
>
> I apologise for this mistake again.

No need to apologize. Reviewers point out potential problems, not to place blame, but to help you improve the patch.

Show 7 quoted lines

> > The actual changes made by the patch are probably reasonable (though I
> > don't have CVS libraries installed presently, so I wasn't able to
> > actually test the changes).
>
> If by testing you mean running the test file to ensure there are no
> errors, I did do it thoroughly before sending the patch,
> so I can vouch for the changes :)

That's very good to hear, and it's the sort of thing you can mention in the patch commentary[1] to help assure reviewers that the patch is sound.

[1]: The commentary area of a patch is just _below_ the "---" line which follows your sign-off. You can use the commentary area to supply readers with notes which aren't necessarily relevant to the commit message itself, but which can help reviewers in other ways.