Re: [PATCH] git-send-email.perl: Add sendmail aliases support

From: Eric Sunshine <sunshine@sunshineco.com>
Date: May 21, 2015, 21:05 UTC
Message-ID: <CAPig+cQFana40n=SCBOC0P2v4Ss7Via3eS6Ms2rU=M9_V_3Osg@mail.gmail.com>
In-Reply-To: <CAJ80satMSCGydLRb5k=xpSqxXSBL=_T7nsHEz3jsuFV9MdmmtA@mail.gmail.com>

On Thu, May 21, 2015 at 4:48 PM, Allen Hubbe <allenbh@gmail.com> wrote:

Show 5 quoted lines

> My motivation for this patch was not really to support the sendmail
> aliases file directly.  The commit message may therefore be
> misleading.  So, I could also rewrite the commit message to say
> something like, "loosely based on" the sendmail aliases format, if the
> exceptions to the format in the current message are not enough.

That probably would be a good idea. After reading the 'aliases' man page you cited[1], I was wondering why your parser diverged from it in so many ways. In addition to lack of support for folded lines, your format:

* only recognizes comment lines when '#' is the first character,
whereas [1] allows whitespace before '#'

* only recognizes zero-length lines as empty, whereas [1] more loosely
interprets a whitespace-only line as empty

* doesn't support quoting the 'name' part of "name: value" as [1] does

> Really, I just prefer the simpler <alias>: <email|alias> syntax
> instead of the ones for mutt, elm, etc, and that is why I wrote this
> patch.

Your patch is missing a documentation update (Documentation/git-send-email.txt) and new tests (t/t9001-send-email.sh).

[1] http://www.postfix.org/aliases.5.html