git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v1 1/2] sequencer: don't abbreviate a command if it doesn't have a short form

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Mar 30, 2020, 18:15 UTC
Message-ID
<CAPig+cQDCqUh9zpUHreS1GqG7hFgV9ChzZj0mtnMbcmVeY0ofQ@mail.gmail.com>
In-Reply-To
<20200330124236.6716-2-alban.gruin@gmail.com>
On Mon, Mar 30, 2020 at 8:43 AM Alban Gruin <alban.gruin@gmail.com> wrote:
> When the sequencer is requested to abbreviate commands, it will replace
> those that does not have a short form (eg. `noop') by a comment mark.
s/does/do/
Show 6 quoted lines
> `noop' serves no purpose, except when fast-forwarding (ie. by running
> `git rebase').  Removing it will break this command when
> `rebase.abbreviateCommands' is set to true.
>
> This changes todo_list_to_strbuf() to check if a command has an actual
> short form, and to ignore it if not.
Perhaps: s/This changes/Change/
> Signed-off-by: Alban Gruin <alban.gruin@gmail.com>
Previous: Junio C HamanoNext: Alban Gruin
Message 10 of 11 in “git rebase fast-forward fails with abbreviateCommands”
  1. Jan Alexander Steffens (heftig)Mar 27, 2020
  2. Alban GruinMar 27, 2020
  3. Elijah NewrenMar 27, 2020
  4. Jan Alexander Steffens (heftig)Mar 27, 2020
  5. Alban GruinMar 28, 2020
  6. Junio C HamanoMar 27, 2020
  7. 0/2 rebase --merge: fix fast forwarding when `rebase.abbreviateCommands' is setAlban Gruin, Mar 30, 2020
  8. 1/2 sequencer: don't abbreviate a command if it doesn't have a short formAlban Gruin, Mar 30, 2020
  9. Junio C HamanoMar 30, 2020
  10. Eric SunshineMar 30, 2020
  11. 2/2 t3432: test `--merge' with `rebase.abbreviateCommands = true', tooAlban Gruin, Mar 30, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.