Re: [RFC PATCH 2/2] http: support omitting data from traces

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jan 18, 2018, 18:25 UTC
Message-ID: <CAPig+cQBysXjoLKRg=tqJnHPdW9jx+TH0=PV-yTyxMqEOtuiMQ@mail.gmail.com>
In-Reply-To: <970dbd7a52de6ab084df8e9ce083bb76ec1889c0.1516235197.git.jonathantanmy@google.com>

On Wed, Jan 17, 2018 at 7:34 PM, Jonathan Tan <jonathantanmy@google.com> wrote:

Show 11 quoted lines

> GIT_TRACE_CURL provides a way to debug what is being sent and received
> over HTTP, with automatic redaction of sensitive information. But it
> also logs data transmissions, which significantly increases the log file
> size, sometimes unnecessarily. Add an option "GIT_TRACE_CURL_NO_DATA" to
> allow the user to omit such data transmissions.
>
> Signed-off-by: Jonathan Tan <jonathantanmy@google.com>
> ---
>  http.c                      | 27 +++++++++++++++++++--------
>  t/t5551-http-fetch-smart.sh | 12 ++++++++++++
>  2 files changed, 31 insertions(+), 8 deletions(-)

Please document GIT_TRACE_CURL_NO_DATA in Documentation/git.txt.