git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/7] revision: use die_for_incompatible_opt3() for --graph/--reverse/--walk-reflogs

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Dec 6, 2023, 17:21 UTC
Message-ID
<CAPig+cQBKk4PpCjT1RN+puS5vSo8_jZ3wONAgGhRvduw3jZT8A@mail.gmail.com>
In-Reply-To
<20231206115215.94467-4-l.s.r@web.de>
On Wed, Dec 6, 2023 at 6:53 AM René Scharfe <l.s.r@web.de> wrote:
> The revision options --reverse is incompatibel with --walk-reflogs and
s/incompatibel/incompatible/
Show 8 quoted lines
> --graph is incompatible with both --reverse and --walk-reflogs.  So they
> are all incompatible with each other.
>
> Use the function for checking three mutually incompatible options,
> die_for_incompatible_opt3(), to perform this check in one place and
> without repetition.  This is shorter and clearer.
>
> Signed-off-by: René Scharfe <l.s.r@web.de>
Previous: René ScharfeNext: René Scharfe
Message 5 of 20 in “standardize incompatibility messages”
  1. 0/7 standardize incompatibility messagesRené Scharfe, Dec 6, 2023
  2. 3/7 revision: use die_for_incompatible_opt3() for --graph/--reverse/--walk-reflogsRené Scharfe, Dec 6, 2023
  3. Patrick SteinhardtDec 6, 2023
  4. René ScharfeDec 6, 2023
  5. Eric SunshineDec 6, 2023
  6. René ScharfeDec 6, 2023
  7. 4/7 revision, rev-parse: factorize incompatibility messages about --exclude-hiddenRené Scharfe, Dec 6, 2023
  8. Patrick SteinhardtDec 6, 2023
  9. René ScharfeDec 6, 2023
  10. Patrick SteinhardtDec 6, 2023
  11. René ScharfeDec 6, 2023
  12. Taylor BlauDec 6, 2023
  13. Patrick SteinhardtDec 7, 2023
  14. 1/7 push: use die_for_incompatible_opt4() for --delete/--tags/--all/--mirrorRené Scharfe, Dec 6, 2023
  15. 2/7 repack: use die_for_incompatible_opt3() for -A/-k/--cruftRené Scharfe, Dec 6, 2023
  16. Taylor BlauDec 6, 2023
  17. 5/7 clean: factorize incompatibility messageRené Scharfe, Dec 6, 2023
  18. 7/7 worktree: simplify incompatibility message for --orphan and commit-ishRené Scharfe, Dec 6, 2023
  19. 6/7 worktree: standardize incompatibility messagesRené Scharfe, Dec 6, 2023
  20. Patrick SteinhardtDec 6, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.