Re: [PATCH v4 09/31] git-remote-mediawiki: Change the behaviour of a split

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jun 12, 2013, 01:54 UTC
Message-ID: <CAPig+cQBDSvGswgspsipeEAVWSXr9YxcqwQj_ne5kRm+eG9vUg@mail.gmail.com>
In-Reply-To: <1370989102-24942-10-git-send-email-celestin.matte@ensimag.fr>

On Tue, Jun 11, 2013 at 6:18 PM, Célestin Matte <celestin.matte@ensimag.fr> wrote:

> A "split ' '" is turned into a "split / /", which changes its behaviour: the
> old method matched a run of whitespaces (/\s*/), while the new one will match a
> single whitespace, which is what we want here. Indeed, in other contexts,

I missed this nit in the last round. '/ /' will match a exactly one space (not an arbitrary whitespace character), so this really should be: s/single whitespace/single space/

Show 7 quoted lines

> changing split(' ') to split(/ /) could potentially be a regression, however,
> here, when parsing the output of "rev-list --parents", whose output SHA-1's are
> each separated by a single space, splitting on a single space is perfectly
> correct.
>
> Signed-off-by: Célestin Matte <celestin.matte@ensimag.fr>
> Signed-off-by: Matthieu Moy <matthieu.moy@grenoble-inp.fr>