Re: [PATCH] makefile: update detect-compiler for newer Xcode version

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Aug 6, 2021, 16:37 UTC
Message-ID: <CAPig+cQBD5HbjoU=rMi=capLS_KFojYAY_OroeBCW3KRsUqamg@mail.gmail.com>
In-Reply-To: <CAPUEspgV3KoUOo=EDss+PTdHO6+Cp=ODDjYm7WRm8F0HHgJ08w@mail.gmail.com>

On Fri, Aug 6, 2021 at 9:33 AM Carlo Arenas <carenas@gmail.com> wrote:

Show 10 quoted lines

> On Fri, Aug 6, 2021 at 5:00 AM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
> > Why not just s/Apple LLVM/Apple clang/?
>
> because that would break it for older versions of Xcode that reported
> themselves as "Apple LLVM" and I am not even sure when the change was
> made to even consider those versions as obsolete.
>
> Either way, I am sure once we figure out which versions are affected
> and which versions macOS developers care enough for, that would be the
> obvious next step.

My daily development machine still reports "Apple LLVM", so it would indeed be premature to `s/Apple LLVM/Apple clang/`. Moreover, there's simply no good reason to `s/Apple LLVM/Apple clang/` since it's not a maintenance burden to leave "Apple LLVM" in the match pattern.