Re: [PATCH 1/3] t7300: add tests to document behavior of clean and nested git

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Apr 7, 2015, 19:40 UTC
Message-ID: <CAPig+cQ9DD8BwG6-KDRqLzJSYh6O7c--GD0TR7-VAf_7PZx+Zw@mail.gmail.com>
In-Reply-To: <1428320904-12366-2-git-send-email-erik.elfstrom@gmail.com>

On Mon, Apr 6, 2015 at 7:48 AM, Erik Elfström <erik.elfstrom@gmail.com> wrote:

Show 16 quoted lines

> Signed-off-by: Erik Elfström <erik.elfstrom@gmail.com>
> ---
> diff --git a/t/t7300-clean.sh b/t/t7300-clean.sh
> index 99be5d9..cfdf6d4 100755
> --- a/t/t7300-clean.sh
> +++ b/t/t7300-clean.sh
> @@ -455,6 +455,88 @@ test_expect_success 'nested git work tree' '
> +test_expect_success 'giving path in nested git work tree will remove it' '
> +       rm -fr foo &&
> +       mkdir foo &&
> +       (
> +               cd foo &&
> +               git init &&
> +               mkdir -p bar/baz &&
> +               cd bar/baz &&
> +               >hello.world

In my earlier review, I utterly forgot to mention the broken &&-chain here and throughout the patch.

Show 8 quoted lines

> +               git add . &&
> +               git commit -a -m nested
> +       ) &&
> +       git clean -f -d foo/bar/baz &&
> +       test -f foo/.git/HEAD &&
> +       test -d foo/bar/ &&
> +       ! test -d foo/bar/baz
> +'