Re: [GSoC] [PATCH v2 1/3] t9811: avoid using pipes to expose exit codes

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Apr 7, 2025, 16:17 UTC
Message-ID: <CAPig+cQ78ubvrEDtW0NKPSxtyv8-4GO8+Mxy0cjJKn2Cvwnxjw@mail.gmail.com>
In-Reply-To: <20250407111824.46518-2-anthonywang03@icloud.com>

On Mon, Apr 7, 2025 at 7:18 AM Anthony Wang <anthonywang513@gmail.com> wrote:

Show 5 quoted lines

> The exit code of the upstream in a pipe is suppressed
> thus we lose any exit codes of git commands that are piped. In order to
> ensure we pick up the exit code, we can write the output of the git command
> to a file, testing the exit codes of both the commands.
> ---

Missing sign-off.

Show 9 quoted lines

> diff --git a/t/t9811-git-p4-label-import.sh b/t/t9811-git-p4-label-import.sh
> @@ -95,9 +95,10 @@ test_expect_success 'two labels on the same changelist' '
> -               git tag | grep TAG_F1 &&
> -               git tag | grep -q TAG_F1_1 &&
> -               git tag | grep -q TAG_F1_2 &&
> +               git tag >output &&
> +               grep TAG_F1 output &&
> +               grep -q TAG_F1_1 output &&
> +               grep -q TAG_F1_2 output &&

Since process creation is so expensive on Microsoft Windows, folks on that platform should also appreciate that this eliminates two git-tag invocations. Nice.