Re: Combining APPLE_COMMON_CRYPTO=1 and NO_OPENSSL=1 produces unexpected result

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jan 15, 2016, 20:28 UTC
Message-ID: <CAPig+cQ5kKAt2_RQnqT7Rn=uGmHV9VvxpQ+UgDPOj=D=pq6arg@mail.gmail.com>
In-Reply-To: <xmqqfuxyisjp.fsf@gitster.mtv.corp.google.com>

On Fri, Jan 15, 2016 at 1:52 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 8 quoted lines

> David Aguilar <davvid@gmail.com> writes:
>> I'm curious to see what others think about dropping CommonCrypto.
>> It seems like a good choice from a maintenance POV.
>
> Judging by a week-long silence, it seems nobody seems to have much
> to say on this issue.  Let me summon the git_osx_installer
> maintainer to hear from somebody who know a lot better than me about
> things around OS X.

Dropping CommonCrypto seems reasonable to me. Since Apple's CommonCrypto provides only a subset of the OpenSSL functionality Git uses, we still end up bringing in OpenSSL anyhow in addition to CommonCrypto, so CommonCrypto isn't buying us much (if anything). Unfortunately, we'd still want to keep the ugly hack to suppress the unavoidable "noise" Apple thrust upon us by populating the OpenSSL headers with #warnings about unstable ABI.