Re: [PATCH] worktree: add: introduce the --name option
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Jul 19, 2016, 18:52 UTC
- Message-ID
- <CAPig+cQ5eGoNFa90__ay+Y7AMP5Zd1VUDXWFCfU1-XX3oEYAkg@mail.gmail.com>
- In-Reply-To
- <xmqq7fchh5bo.fsf@gitster.mtv.corp.google.com>
On Tue, Jul 19, 2016 at 2:04 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 19 quoted lines
> Antoine Tenart <antoine.tenart@ack.tf> writes: >> Adds a --name option allowing to specify the name of a worktree when >> creating it. This allows to have multiple worktrees in directories >> having the same name (e.g. project0/foo, project1/foo etc...). This >> commit keeps the previous behaviour by making it the default value, i.e. >> by using $(basename <path>) as the worktree name when the --name option >> isn't used. > > Hmm, is this related to an earlier discussion > > https://public-inbox.org/git/20160625051548.95564-1-barret%40brennie.ca/ > > in any way, or is it an independent invention? > > The conclusion of that discussion thread was roughly "users > shouldn't even _care_ about the name, and if they have to use name > to identify the worktrees to do certain things right now, reducing > the need for such 'certain things', not making it easy to give a > user-defined name to a worktree, is the way to go", IIRC.
Yes, that's correct. The discussion wandered a bit before starting to converge at [1] and concluding at [2].
[1]: https://public-inbox.org/git/CAPig%2BcRNUZZBw%3DF-Q2f3Ehc-8T2iBp4kvDusNRGv4ea5nihQVQ%40mail.gmail.com/ [2]: https://public-inbox.org/git/CAPig%2BcSEwib1iFyWE5h8-qTbsAC%2BzsaSDSYQnv6otWoOOjWAeA%40mail.gmail.com/