Re: [PATCH 05/12] pretty: save commit encoding from logmsg_reencode if the caller needs it
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Mar 17, 2013, 08:57 UTC
- Message-ID
- <CAPig+cQ52J=21Z5JVq2ifZKVAiDSHBYr=_Db7L6k+Lr2tLgHBQ@mail.gmail.com>
- In-Reply-To
- <1363400683-14813-6-git-send-email-pclouds@gmail.com>
On Fri, Mar 15, 2013 at 10:24 PM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:
> The commit encoding is parsed by logmsg_reencode, there's no need for > the caller to re-parse it again. The reencoded message now have the
s/have/has/
> new encoding, not the original one. The caller would need to read > commit object again before parsing.