Re: [PATCH 3/3] cat-file: add --follow-symlinks to --batch

From: Eric Sunshine <sunshine@sunshineco.com>
Date: May 8, 2015, 19:51 UTC
Message-ID: <CAPig+cQ2p439dtMwbUEpWdxFB4gf3iuaataab=ghJ6Jm1Snv6w@mail.gmail.com>
In-Reply-To: <1431108819-6831-3-git-send-email-dturner@twopensource.com>

On Fri, May 8, 2015 at 2:13 PM,  <dturner@twopensource.com> wrote:

Show 17 quoted lines

> This wires the in-repo-symlink following code through to the cat-file
> builtin.  In the event of an out-of-repo link, cat-file will print
> the link in a new format.
>
> Signed-off-by: David Turner <dturner@twitter.com>
> ---
> diff --git a/builtin/cat-file.c b/builtin/cat-file.c
> index df99df4..277af32 100644
> --- a/builtin/cat-file.c
> +++ b/builtin/cat-file.c
> @@ -369,6 +377,9 @@ int cmd_cat_file(int argc, const char **argv, const char *prefix)
>                 OPT_SET_INT('p', NULL, &opt, N_("pretty-print object's content"), 'p'),
>                 OPT_SET_INT(0, "textconv", &opt,
>                             N_("for blob objects, run textconv on object's content"), 'c'),
> +               OPT_SET_INT(0, "follow-symlinks", &batch.follow_symlinks,
> +                       N_("Follow in-repo symlinks; report out-of-repo symlinks (requires --batch or --batch-check)"),
> +                           1),

Capitalization is not used for descriptions of the other options.

>                 { OPTION_CALLBACK, 0, "batch", &batch, "format",
>                         N_("show info and content of objects fed from the standard input"),
>                         PARSE_OPT_OPTARG, batch_option_callback },