git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] docs: add headers in MyFirstObjectWalk

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Oct 30, 2021, 07:49 UTC
Message-ID
<CAPig+cQ2TXZtZphdkWQP9W218YUpL3mFbDo1j4Z+SjmACMfDEg@mail.gmail.com>
In-Reply-To
<224a256e-8700-047d-bc12-834524a3c8f3@gmail.com>
On Sat, Oct 30, 2021 at 3:33 AM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
Show 6 quoted lines
> On 27/10/21 21.05, John Cai via GitGitGadget wrote:
> > In several places, headers need to be included or else the code won't
> > compile. Since this is the first object walk, it would be nice to
> > include them in the tutorial to make it easier to follow.
>
> Patch title should be "#include missing headers" (dunno?)

If the series was being rerolled for some other reason, making the commit subject slightly more precise like that might make sense, but rerolling only for that reason is probably not worth the extra work for the submitter, the maintainer, and reviewers.

Previous: Bagas SanjayaNext: John Cai via GitGitGadget
Message 8 of 16 in “fix up example code in MyFirstObjectWalk tutorial”
  1. 0/2 fix up example code in MyFirstObjectWalk tutorialJohn Cai via GitGitGadget, Oct 27, 2021
  2. 1/2 docs: fix places that break compliation in MyFirstObjectWalkJohn Cai via GitGitGadget, Oct 27, 2021
  3. Eric SunshineOct 27, 2021
  4. 2/2 docs: add headers in MyFirstObjectWalkJohn Cai via GitGitGadget, Oct 27, 2021
  5. Eric SunshineOct 27, 2021
  6. Junio C HamanoOct 27, 2021
  7. Bagas SanjayaOct 30, 2021
  8. Eric SunshineOct 30, 2021
  9. 0/2 fix up example code in MyFirstObjectWalk tutorialJohn Cai via GitGitGadget, Oct 29, 2021
  10. 1/2 docs: fix places that break compilation in MyFirstObjectWalkJohn Cai via GitGitGadget, Oct 29, 2021
  11. Eric SunshineOct 29, 2021
  12. 2/2 docs: add headers in MyFirstObjectWalkJohn Cai via GitGitGadget, Oct 29, 2021
  13. 0/2 fix up example code in MyFirstObjectWalk tutorialJohn Cai via GitGitGadget, Oct 29, 2021
  14. 1/2 docs: fix places that break compilation in MyFirstObjectWalkJohn Cai via GitGitGadget, Oct 29, 2021
  15. 2/2 docs: add headers in MyFirstObjectWalkJohn Cai via GitGitGadget, Oct 29, 2021
  16. Eric SunshineOct 29, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.