Re: [PATCH v3 1/1] rebase: fix --fork-point with short refname

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Dec 11, 2019, 16:02 UTC
Message-ID: <CAPig+cQ-3Ds41hr91fRo_GvuFMTP7zNVJtaSqi-Yccq4Pk-8Qg@mail.gmail.com>
In-Reply-To: <20191211122136.GA46399@generichostname>

On Wed, Dec 11, 2019 at 7:20 AM Denton Liu <liu.denton@gmail.com> wrote:

Show 10 quoted lines

> > +test_expect_success "git rebase --fork-point with ambigous refname" "
> > +     git checkout master &&
> > +     git checkout -b one &&
> > +     git checkout side &&
> > +     git tag one &&
> > +     test_must_fail git rebase --fork-point --onto D one
> > +"
>
> nit: use double-quotes instead of single-quotes to surround both the
> test case name and the actual code itself.

Denton meant to say that you should single-quote the test title and test body (not double-quote). In this particular test, the distinction doesn't matter presently, though it could matter if the test is later changed. In particular, if the test does any sort of variable interpolation (such as $foo), then the single quotes ensure that the interpolation will occur when the test is actually run (which is almost always what is desired) rather than at the time the test is defined (which is almost never wanted).