Re: [PATCH 2/4] t6423: more involved directory rename test

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Oct 15, 2020, 20:57 UTC
Message-ID: <CAPig+cQ=WjqfN68GcpaJBC4zjP_q2KnY9k15ErWkFM08TyCVjA@mail.gmail.com>
In-Reply-To: <c9637d70caed8a265096fa701833eca3ed52d0f3.1602794791.git.gitgitgadget@gmail.com>

On Thu, Oct 15, 2020 at 4:46 PM Elijah Newren via GitGitGadget <gitgitgadget@gmail.com> wrote:

> Add a new testcase modelled on a real world repository example that
> served multiple purposes:

A couple minor style nits I noticed while quickly running my eye over the patch...

> +               for i in `test_seq 1 88`; do
> +                       echo content $i >dir/unchanged/file_$i
> +               done &&

'do' on its own line, and prefer $(...) over `...`:

    for i in $(test_seq 1 88)
    do
        echo content $i >dir/unchanged/file_$i
    done &&

(Not necessarily worth a re-roll, though.)