Re: [PATCH v3] worktree: clarify that --expire only affects missing worktrees
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Jan 30, 2026, 00:29 UTC
- Message-ID
- <CAPig+cQ+HWZDb5ArGBq8PkXu1X6Dwe79w0sVjX9uRm7PcEwyNQ@mail.gmail.com>
- In-Reply-To
- <pull.2135.v3.git.git.1769578785381.gitgitgadget@gmail.com>
On Wed, Jan 28, 2026 at 12:39 AM Sam Bostock via GitGitGadget <gitgitgadget@gmail.com> wrote:
Show 19 quoted lines
> The --expire option for "git worktree list" and "git worktree prune" > only affects worktrees whose working directory path no longer exists. > The help text did not make this clear, and the documentation > inconsistently used "unused" for prune but "missing" for list. > > Update the help text and documentation to consistently describe these > as "missing worktrees", and use "prune" instead of "expire" when > describing the effect on missing worktrees since the terminology is > clearer. > > While at it, expand the description of the "prune" subcommand itself > to better explain what it does and when to use it, as suggested by > Junio. > > Signed-off-by: Sam Bostock <sam@sambostock.ca> > --- > Changes from v2: > * Squash into a single commit > * Expand the prune subcommand description per Junio's suggestion
Thanks for re-rolling this patch. I think this version addresses all the review comments from Junio and myself and is ready to be merged to "next".