git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 04/12] remote.c: provide per-branch pushremote name

From
Eric Sunshine <sunshine@sunshineco.com>
Date
May 5, 2015, 19:48 UTC
Message-ID
<CAPig+cQ+AbgTXAWKaN4obdGLWFDxjfr4yAaJZgvnLLzzoqdPRQ@mail.gmail.com>
In-Reply-To
<20150505193339.GF10463@peff.net>
On Tue, May 5, 2015 at 3:33 PM, Jeff King <peff@peff.net> wrote:
Show 17 quoted lines
> On Sun, May 03, 2015 at 12:51:13AM -0400, Eric Sunshine wrote:
>
>> > Versus v1, I did something a little clever by passing a function pointer
>> > around (versus a flag and letting the caller do a conditional based on
>> > the flag). Too clever?
>>
>> FWIW: I found this "clever" version easy enough to follow.
>>
>> However, if you push a tiny bit of the work into the callers of
>> remote_get_1(), then you can do away with the "cleverness" altogether,
>> can't you? Something like this:
>
> Yeah, it's just that it goes in the opposite direction I was trying for,
> which is to have as little code as possible in the wrapper functions (in
> fact, I think after my changes you could even bump the read_config()
> call into remote_get_1; before my changes, it depended on the pushremote
> config being set before the call).

I also noticed that read_config() could be moved into remote_get_1(). In fact, with that change, then the wrappers really do collapse nicely to 1-liners, so the "clever" function pointer approach probably is cleaner; and it's nicely generalized over the previous round with the boolean argument to remote_get_1().

Previous: Jeff KingNext: Jeff King
Message 11 of 21 in “implement @{push} shorthand”
  1. 0/12 implement @{push} shorthandJeff King, May 1, 2015
  2. 01/12 remote.c: drop default_remote_name variableJeff King, May 1, 2015
  3. 02/12 remote.c: drop "remote" pointer from "struct branch"Jeff King, May 1, 2015
  4. Eric SunshineMay 3, 2015
  5. Jeff KingMay 5, 2015
  6. Jeff KingMay 7, 2015
  7. 03/12 remote.c: hoist branch.*.remote lookup out of remote_get_1Jeff King, May 1, 2015
  8. 04/12 remote.c: provide per-branch pushremote nameJeff King, May 1, 2015
  9. Eric SunshineMay 3, 2015
  10. Jeff KingMay 5, 2015
  11. Eric SunshineMay 5, 2015
  12. Jeff KingMay 7, 2015
  13. Eric SunshineMay 8, 2015
  14. 05/12 remote.c: introduce branch_get_upstream helperJeff King, May 1, 2015
  15. 06/12 remote.c: report specific errors from branch_get_upstreamJeff King, May 1, 2015
  16. 07/12 remote.c: add branch_get_pushJeff King, May 1, 2015
  17. 08/12 sha1_name: refactor upstream_markJeff King, May 1, 2015
  18. 09/12 sha1_name: refactor interpret_upstream_markJeff King, May 1, 2015
  19. 10/12 sha1_name: implement @{push} shorthandJeff King, May 1, 2015
  20. 11/12 for-each-ref: use skip_prefix instead of starts_withJeff King, May 1, 2015
  21. 12/12 for-each-ref: accept "%(push)" formatJeff King, May 1, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.