Re: [GSoC][PATCH 5/5] t: add test for git refs optimize subcommand

From: Meet Soni <meetsoni3017@gmail.com>
Date: Aug 31, 2025, 06:20 UTC
Message-ID: <CAPhwyn0r11owkcSLXDALfPjKe1QvexC0uH6F7B=vktwfAue53w@mail.gmail.com>
In-Reply-To: <aK3QOtQzUFsGvmyA@ArchLinux>

Thanks for the review, and apologies for missing your email earlier, I just saw your comments today.

On Tue, 26 Aug 2025 at 20:48, shejialuo <shejialuo@gmail.com> wrote:

Show 22 quoted lines

>
> On Tue, Aug 26, 2025 at 01:06:45PM +0530, Meet Soni wrote:
>
> > diff --git a/t/t1463-refs-optimize.sh b/t/t1463-refs-optimize.sh
> > new file mode 100755
> > index 0000000000..c11c905d79
> > --- /dev/null
> > +++ b/t/t1463-refs-optimize.sh
> > @@ -0,0 +1,17 @@
> > +#!/bin/sh
> > +
> > +test_description='git refs optimize should not change the branch semantic
> > +
> > +This test runs git refs optimize and git show-ref and checks that the branch
> > +semantic is still the same.
> > +'
>
> When reading the description, I am wondering how this test runs `git
> refs optimize` and `git show-ref` to achieve the goal. Should we simply
> just say we use "pack-refs-tests.sh" to ensure the compatibility with
> the `git pack-refs`?
>

You're right that the current description is too tied to implementation details (git show-ref). The intent of this test is to ensure that git refs optimize does not change branch semantics, similar to the existing pack-refs tests.

I'll update the description to focus on the behavior being verified, not the specific commands used.

Show 16 quoted lines

> > +
> > +GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
> > +export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
> > +GIT_TEST_DEFAULT_REF_FORMAT=files
> > +export GIT_TEST_DEFAULT_REF_FORMAT
> > +
> > +. ./test-lib.sh
> > +
> > +pack_refs='refs optimize'
> > +. "$TEST_DIRECTORY"/pack-refs-tests.sh
> > --
> > 2.34.1
> >
>
> Thanks,
> Jialuo

Thanks, Meet