git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git pull --upload-pack reversion in git 2.5.0

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 30, 2015, 18:41 UTC
Message-ID
<CAPc5daXPY7RQSM6oyFYJ2LjYjaT9dDG-+3=nbHONirGh50pdBA@mail.gmail.com>
In-Reply-To
<20150730183144.GA6360@kitenet.net>
On Thu, Jul 30, 2015 at 11:31 AM, Joey Hess <id@joeyh.name> wrote:
> I think this comes down to a lack of quoting where git-pull runs
> git-fetch. Before eb2a8d9ed3fca2ba2f617b704992d483605f3bb6,
> "$@" was passed through to git-fetch, but now there is a $upload_pack
> which is passed without being quoted.
Yes, it is not just the matter of using "$upload_pack", though ;-)
${upload_pack+"$upload_pack"} or something.
Previous: Joey HessNext: Matthieu Moy
Message 4 of 8 in “git pull --upload-pack reversion in git 2.5.0”
  1. Joey HessJul 30, 2015
  2. Matthieu MoyJul 30, 2015
  3. Joey HessJul 30, 2015
  4. Junio C HamanoJul 30, 2015
  5. pull.sh: quote $upload_pack when passing it to git-fetchMatthieu Moy, Jul 30, 2015
  6. Junio C HamanoJul 30, 2015
  7. Paul TanJul 31, 2015
  8. Junio C HamanoJul 31, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.