Re: [PATCH 0/7] nd/repack-keep-pack update

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 14, 2018, 22:38 UTC
Message-ID: <CAPc5daXHJCbuxv2NE1KUt3pYtP1p1RQhOT5ceb0++spEJZ5dTQ@mail.gmail.com>
In-Reply-To: <878t9pfu4f.fsf@evledraar.gmail.com>

On Sun, Apr 15, 2018 at 4:47 AM, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

Show 5 quoted lines

>
> The only (trivial) issue I found in the patches themselves was that
> between 4/5 and 5/7 you're adding an empty line to config.txt in 4/7
> just to erase it in 5/7, better not to add it to begin with, but
> hopefully Junio can fix that up (if he cares).

I do care but I'd wish I do not have to waste time and concentration to spend on doing so, even though I would be fully capable of skipping this round and remembering to queue a rerolled one.

I've seen mentions like the above one a few times on the list recently, so let me make it clear. Some things are easier to tweak locally than others, and I'd rather not to waste my time on cleaning other people's mess. A simple typofix that does not cascade through to later steps in a series is one thing. A tweak that changes number of lines in a hunk that forces a later step to compensate is more involved.

Don't expect your traffic cop to wash your care while you're stopping at a red signal.