Re: [PATCH 6/6] diff.c: detect blocks despite whitespace changes
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 29, 2017, 23:51 UTC
- Message-ID
- <CAPc5daXBprMyWeQmcUem_Yw9bsyTD8-C818+t94cy5K3onw8Og@mail.gmail.com>
- In-Reply-To
- <CAGZ79kaq2ym9aSAcHXRSd=onkqjoO-2_0B8PHed2j4q_9gwvCA@mail.gmail.com>
On Thu, Jun 29, 2017 at 2:01 PM, Stefan Beller <sbeller@google.com> wrote:
Show 7 quoted lines
> On Tue, Jun 27, 2017 at 10:06 PM, Junio C Hamano <gitster@pobox.com> wrote: >> Junio C Hamano <gitster@pobox.com> writes: >> This probably deserves a bit more illustration of how I envision the >> code should evolve. >> ... > It turns out that the code here is rather a very loose proposal, > not to be copied literally,
Yeah, whenever I say "illustration", do not take it as anything more than scribbling on the back of an envelope, whose primary purpose is to show some idea (in this case, the central idea is that a helper function that lets you ask "what's the next byte that matters? tell me also when you run out" is all you need to do an in-place comparison with various "ignore" modes; by the way, that applies also to ignore-case comparison if there is a need to support it).
The implementation detail to support that central idea is left to the readers. ;-)
Thanks.