Re: [PATCH] makefile: add ability to run specific test files

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 10, 2014, 04:14 UTC
Message-ID: <CAPc5daWNB0m23tPdYxWmQEpu8PshFWwwZ3n_bSxF6evwM7-61g@mail.gmail.com>
In-Reply-To: <1404949763.23510.42.camel@jekeller-desk1.amr.corp.intel.com>

On Wed, Jul 9, 2014 at 4:49 PM, Keller, Jacob E <jacob.e.keller@intel.com> wrote:

Show 7 quoted lines

> On Wed, 2014-07-09 at 15:59 -0700, Junio C Hamano wrote:
>>
>> What kind of things are missing, exactly?  Perhaps that is something
>> you need to fix, instead of mucking with the top-level Makefile.
>
> It uses the git from my environment instead of the git I have built,
> which is bad since I don't really want to run make install.

Are you sure about that?  Try adding something like

  die("I am broken");

at the very beginning of main() in git.c, rebuild your git (i.e. "make", not "make install") and then

  $ cd t
  $ sh ./t1234-test.sh -v

for any of the test scripts. You should see any test piece that runs "git" sees "git" dying with that message.

Otherwise, there is something wrong with git you are building. Unless you have a patch or two to t/test-lib.sh or something that breaks the test framework, you should be able to test what you just have built without getting affected by what is installed in your $PATH. After all, that is how we bootstrap git from a tarball without any installed version, and friends do not force friends install without testing first ;-)