Re: BUG: git rebase shows different commit message

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 14, 2020, 17:55 UTC
Message-ID: <CAPc5daVAJxfZVz0HwTFwhq-EfERrESU2Ta6-0fAyXrzf3YJREg@mail.gmail.com>
In-Reply-To: <703071109.20201014201106@yandex.ru>

Show 20 quoted lines

> $git log --graph --decorate --pretty=oneline --abbrev-commit
> * 093010ea (local/dev) Change column 'Label' => 'OPFG' and added column 'comment'
> * 86221a47  Updated OpenAPI schema according to SCHEMA 193
> * 6202eb08 Added opfg.html
>
> $git rebase -i --autostash --rebase-merges 86221a47^
> label onto
>
> reset onto
> pick 86221a47 Updated OpenAPI schema according to SCHEMA 193
> pick 093010ea Change column 'Label' => 'OPFG' and added column 'comment'
>
> Here commit message is shown without leading space.
> I  think  that this is wrong. Because if space was shown then I reword
> commit message
>
> r 86221a47 Updated OpenAPI schema according to SCHEMA 193
> pick 093010ea Change column 'Label' => 'OPFG' and added column 'comment'
>
> but now I just do not see that I shold reword it =(

These one-line titles are shown to help you identify the commit to futz with, not to help you review them. After all, you see only titles here without the body of the log message [*1*].

Besides, if the "breakage" in the title were not just an extra whitespace but some control characters that take the terminal into an insane state, we should sanitize the title we'd show here for identification purposes, so "show the title as-is" is not a good idea to begin with.

So, NAK.

[Footnote] *1* ... and if majority of your commits have a single-liner titles, I cannot imagine how these logs can be useful to its consumers (i.e. those who use "git show" after identifying an old commit that broke things using "git bisect" or "git blame").

A leading whitespace in such a "git log" output would be the least of your problems in such a history, I would have to say.