git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v6 05/11] trace: add infrastructure to augment trace output with additional info

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 21, 2014, 00:33 UTC
Message-ID
<CAPc5daV=vbJz90X9K85DzJZ0PjyzF_xfSi9Cy9XZ+TX0YdEkeg@mail.gmail.com>
In-Reply-To
<53A4C47D.609@gmail.com>
On Fri, Jun 20, 2014 at 4:32 PM, Karsten Blees <karsten.blees@gmail.com> wrote:
Show 11 quoted lines
> Am 21.06.2014 00:33, schrieb Junio C Hamano:
>> Karsten Blees <karsten.blees@gmail.com> writes:
>
> GIT_TRACE_VERBOSE perhaps? It affects all trace output, not just
> GIT_TRACE_PERFORMANCE. The tests would still have to disable it
> explicitly, though, in case someone sets it in their profile.
>
> However, IIRC conclusion of v4 discussion was that this would be
> useful for all trace output [1], so I think it should be the default.
>
> [1] https://groups.google.com/forum/#!topic/msysgit/UMKTvmZX5aI
Hmph, after re-reading of that thread, I recall that I thought Peff's
>> Would it make
>> sense to just tie this to regular trace_* calls, and if
>> GIT_TRACE_PERFORMANCE is set, add a timestamp to each line?

was the conclusion (i.e. by default no change, ask with GIT_TRACE_PERFORMANCE), and that I found that reasonable back then.

As to the need to disable in the tests, yes, you are right. Just like we give predictiable environment to tests by setting EDITOR, HOME, etc. in test-lib.sh, we should do the same for these new settings there.

Thanks.
-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Previous: Karsten BleesNext: Karsten Blees
Message 9 of 17 in “add performance tracing facility”
  1. 00/11 add performance tracing facilityKarsten Blees, Jun 20, 2014
  2. 01/11 trace: move trace declarations from cache.h to new trace.hKarsten Blees, Jun 20, 2014
  3. 02/11 trace: consistently name the format parameterKarsten Blees, Jun 20, 2014
  4. 03/11 trace: remove redundant printf format attributeKarsten Blees, Jun 20, 2014
  5. 04/11 trace: factor out printing to the trace fileKarsten Blees, Jun 20, 2014
  6. 05/11 trace: add infrastructure to augment trace output with additional infoKarsten Blees, Jun 20, 2014
  7. Junio C HamanoJun 20, 2014
  8. Karsten BleesJun 20, 2014
  9. Junio C HamanoJun 21, 2014
  10. 06/11 trace: add current timestamp to all trace outputKarsten Blees, Jun 20, 2014
  11. 07/11 trace: move code around, in preparation to file:line outputKarsten Blees, Jun 20, 2014
  12. 08/11 trace: add 'file:line' to all trace outputKarsten Blees, Jun 20, 2014
  13. 09/11 trace: add high resolution timer function to debug performance issuesKarsten Blees, Jun 20, 2014
  14. 10/11 trace: add trace_performance facility to debug performance issuesKarsten Blees, Jun 20, 2014
  15. 11/11 git: add performance tracing for git's main() function to debug scriptsKarsten Blees, Jun 20, 2014
  16. Philip OakleyJun 20, 2014
  17. Karsten BleesJun 20, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.